Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let go YAML's not_found exception #4249

Merged
merged 2 commits into from
Dec 10, 2024
Merged

let go YAML's not_found exception #4249

merged 2 commits into from
Dec 10, 2024

Conversation

martinkirch
Copy link
Contributor

this would avoid #4248, where I didn't notice that yaml was an optional dependency

@toots
Copy link
Member

toots commented Dec 9, 2024

Thanks for the PR! I'm not sure if that would do anything. This file is simply ignored when the yaml optional opam package is not present so anything in its code is also silenced.

@martinkirch
Copy link
Contributor Author

I tested it by running opam uninstall yaml. It recompiled my pinned liquidsoap (that's how I usually test the main branch) and the exception was still raised.

@toots
Copy link
Member

toots commented Dec 9, 2024

My bad, I forgot this code was organized in a different way.. merging, thanks!

@toots toots enabled auto-merge December 9, 2024 23:36
@toots toots added this pull request to the merge queue Dec 9, 2024
Merged via the queue into savonet:main with commit 0943c07 Dec 10, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinkirch @toots